Feature: GUI Client Scan mode Center/Span in addition to Start/Stop#107
Open
FlorenceBerterottiere wants to merge 7 commits into
Open
Feature: GUI Client Scan mode Center/Span in addition to Start/Stop#107FlorenceBerterottiere wants to merge 7 commits into
FlorenceBerterottiere wants to merge 7 commits into
Conversation
Collaborator
Author
|
I want to flag that this PR still contains the bug that I disclose here : #109 |
aferk
marked this pull request as draft
May 27, 2026 09:43
FlorenceBerterottiere
marked this pull request as ready for review
May 27, 2026 10:51
Collaborator
|
@FlorenceBerterottiere Please rebase on latest main |
…an mode, where the center value is the previously calibrated value and the span is provided by the user
Center/span mode (and manual input) could produce scan ranges outside the min/max values defined by the experiment library, e.g. a negative TimeParameter. Now the frontend clamps start/stop to the allowed range at submit time before generating the scan values, and the server snaps any remaining out-of-range value to the nearest bound (also absorbing linspace floating-point overshoot at the endpoints) instead of persisting it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Center and span are reconstructed from start/stop on every render, so a typed 0.0151 came back as 0.015099999999996783 through the binary float round-trip. Round both to 12 significant digits, well below the ~16-digit noise floor and far above any physically meaningful precision. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
FlorenceBerterottiere
force-pushed
the
feature/span_points_scan
branch
from
July 13, 2026 14:00
f8ee949 to
7cd7070
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

added the option to scan either in start/stop mode, or with center/span mode, where the center value is the previously calibrated value and the span is provided by the user.
Fix to issue #84